Adds containsExactlyInAnyOrder to iterable and primitive / float arrays. #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kritarie
force-pushed
the
contains-exactly-in-any-order
branch
from
0ea4eb5
to
d299288
Compare
evant
reviewed
Aug 31, 2020
| @@ -73,6 +74,40 @@ fun Assert<Iterable<*>>.containsOnly(vararg elements: Any?) = given { actual -> | |||
| }.toString()) | |||
| } | |||
|
|
|||
| /** | |||
| * Asserts the iterable contains exactly the expected elements, in any order. | |||
There was a problem hiding this comment.
Think this doc could be more descriptive in describing the different between this and the other contains methods.
| }.toString()) | ||
| } | ||
|
|
||
| internal fun MutableList<*>.removeFirst(value: Any?) { |
There was a problem hiding this comment.
Any reason this isn't private?
There was a problem hiding this comment.
Nah, it should be private
Kritarie
force-pushed
the
contains-exactly-in-any-order
branch
from
d299288
to
e4f3c19
Compare
evant
approved these changes
Sep 1, 2020
Kritarie
force-pushed
the
contains-exactly-in-any-order
branch
from
e4f3c19
to
31d69f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.