Allow override of assertion context's error message display. #313
Conversation
| override fun <R> assertThat(actual: R, name: String?): Assert<R> = | ||
| ValueAssert(actual, name, if (context != null || this.value === actual) context else this.value) | ||
| override fun <R> assertThat(actual: R, name: String?): Assert<R> { | ||
| val newContext = if (context.originatingSubject != null || this.value == actual) { |
There was a problem hiding this comment.
Passing only a flag was not enough, since the original implementation ran this comparison to determine whether an Assert is considered "transformed". For this reason, I introduced an internal type AssertingContext that simply holds the original value along with its display function.
| value = actual, | ||
| name = name, | ||
| context = AssertingContext( | ||
| originatingSubject = null, |
There was a problem hiding this comment.
I admit this looks a little confusing, but this most closely aligns with the original implementation - the originatingSubject is null until the Assert is transformed.
There was a problem hiding this comment.
Would making null the default value of the param make it more clear?
There was a problem hiding this comment.
Actually, think it might make sense to pull all of this into the AssertingContext's constructor.
There was a problem hiding this comment.
Do you mean like defer the currying as well?
context = AssertingContext(actual, displayActual)Actually, would have to erase T before passing. So more like
context = AssertingContext { displayActual(actual) }By default, contexts whose type is not known will fall back to its .toString(), which may not be desirable for some cases.
Kritarie
force-pushed
the
override-context-display
branch
from
a8c8b4b
to
590bdbd
Compare
By default, contexts whose type is not known will fall back to its .toString(), which may not be desirable for some cases.
Addresses #232