Double array fixes #312
Merged
Double array fixes #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evant
force-pushed
the
double-array-fixes
branch
from
b9ff34b
to
6a168cf
Compare
The old methods were deprecated in kotlin 1.4.0. This is because they don't compare NaN equal to itself which while technically correct can be surprising. Changed the implementations to use `asList().contains()` instead which will compare NaN equal to itself which is useful in a testing context.
evant
force-pushed
the
double-array-fixes
branch
from
6a168cf
to
4229b84
Compare
Kritarie
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.