Convert Assert<String> extensions into Assert<CharSequence> extensions. #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evant
requested changes
Aug 14, 2020
| fun Assert<CharSequence?>.isEqualTo(other: CharSequence?, ignoreCase: Boolean = false) = given { actual -> | ||
| val actualString = actual?.toString() | ||
| val otherString = other?.toString() | ||
| if (actualString.equals(otherString, ignoreCase)) return |
There was a problem hiding this comment.
So it's possible for a CharSequence to not be equal but their toString() representations to be equal (Think spanned strings on android). Think we need to keep these only for String.
| * @param ignoreCase true to compare ignoring case, the default if false. | ||
| * @see [isEqualTo] | ||
| */ | ||
| fun Assert<CharSequence?>.isNotEqualTo(other: CharSequence?, ignoreCase: Boolean = false) = given { actual -> |
Kritarie
force-pushed
the
string-to-charsequence
branch
from
367c383
to
ce77b28
Compare
evant
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the diff is a simple cut-paste from
strings.ktandStringTest.kttocharsequence.ktandCharSequence.kt.Slight modifications were required for
isEqualToandisNotEqualTo, as they both relied on theString?extension of.equalsin the standard lib.Also adds two tests that caught a bug I introduced with this change, specifically when comparing
nullto"null"Couple thoughts: