Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat] Suport .gitignore and .eslintignore files to populate ignore list #74

Open
phoenisx opened this issue Sep 19, 2022 · 2 comments · Fixed by #82
Open

[Feat] Suport .gitignore and .eslintignore files to populate ignore list #74

phoenisx opened this issue Sep 19, 2022 · 2 comments · Fixed by #82
Assignees
@phoenisx
Labels
breaking-change enhancement New feature or request good first issue Good for newcomers
Milestone
v3.0

Comments

@phoenisx
Copy link
Contributor

cssvar.ignore can be tedious to maintain, and ignore list can be random for different projects.
Adding support for .gitignore and .eslintignore files opens an opportunity to keep less things inside the extension config and re-use config files that are widely used.

Gotchas:

  • If a folder (like node_modules) is ignored in .gitignore and later user wants to import a css file from node_modules, the extension should not ignore such CSS imports from node_modules.
    • I guess this should be possible using !node_modules glob pattern in cssvar.ignore settings, which will supersede all other ignore patterns.
@phoenisx phoenisx added the enhancement New feature or request label Sep 19, 2022
@phoenisx phoenisx self-assigned this Sep 19, 2022
@phoenisx phoenisx added the good first issue Good for newcomers label Sep 19, 2022
@phoenisx phoenisx added this to the 2.4.0 milestone Oct 5, 2022
@phoenisx
Copy link
Contributor Author

phoenisx commented Oct 5, 2022

This issue will only support .gitignore files.

Support for .eslintignore can be added on demand later, if ever needed.

phoenisx added a commit that referenced this issue Oct 16, 2022
@phoenisx
[#74] feat: use globby for .gitignore support
3b59b3f
@phoenisx phoenisx mentioned this issue Oct 16, 2022
Merged
phoenisx added a commit that referenced this issue Oct 16, 2022
@phoenisx
[#74] feat: use globby for .gitignore support
26d5f8c
phoenisx added a commit that referenced this issue Oct 21, 2022
@phoenisx
revert: #74 support for .gitignore
575ceff
@phoenisx phoenisx mentioned this issue Oct 21, 2022
Merged
phoenisx added a commit that referenced this issue Oct 21, 2022
@phoenisx
Merge pull request #84 from willofindie/revert/issue-74-gitignore-sup…
840613a 
…port

[Revert] #74 Support for `.gitignore`
@phoenisx phoenisx reopened this Oct 21, 2022
@phoenisx
Copy link
Contributor Author

I will wait to work on this.
I think creating a small library to provide this functionality and also support glob patterns would be an interesting project to work on. 😅

@phoenisx phoenisx mentioned this issue Nov 1, 2022
Open
8 tasks
@phoenisx phoenisx modified the milestones: 2.4.0, v3.0 Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@phoenisx phoenisx

Labels
breaking-change enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
v3.0
Development

Successfully merging a pull request may close this issue.

[Feat] Add support for .gitignore files willofindie/vscode-cssvar
1 participant
@phoenisx