Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console.bell #310

Merged
merged 12 commits into from
Oct 3, 2020
Merged

Console.bell #310

merged 12 commits into from
Oct 3, 2020

Conversation

willmcgugan
Copy link
Collaborator

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Please describe your changes here. If this fixes a bug, please link to the issue, if possible.

@codecov
Copy link

codecov bot commented Sep 30, 2020

Codecov Report

Merging #310 into master will increase coverage by 0.20%.
The diff coverage is 97.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage   98.91%   99.11%   +0.20%     
==========================================
  Files          50       50              
  Lines        4249     4308      +59     
==========================================
+ Hits         4203     4270      +67     
+ Misses         46       38       -8     
Flag Coverage Δ
#unittests 99.11% <97.94%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/default_styles.py 100.00% <ø> (ø)
rich/logging.py 100.00% <ø> (ø)
rich/containers.py 98.82% <50.00%> (-0.02%) ⬇️
rich/syntax.py 95.77% <83.33%> (+4.10%) ⬆️
rich/pretty.py 99.41% <96.66%> (-0.59%) ⬇️
rich/color.py 100.00% <100.00%> (ø)
rich/console.py 100.00% <100.00%> (ø)
rich/constrain.py 100.00% <100.00%> (ø)
rich/panel.py 100.00% <100.00%> (ø)
rich/progress.py 94.66% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33a171d...5403640. Read the comment docs.

@willmcgugan willmcgugan merged commit d9d59c6 into master Oct 3, 2020
@willmcgugan willmcgugan deleted the bell branch October 3, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant