Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimized divide #2385

Merged
merged 4 commits into from Jul 11, 2022
Merged

optimized divide #2385

merged 4 commits into from Jul 11, 2022

Conversation

willmcgugan
Copy link
Collaborator

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

Please describe your changes here. If this fixes a bug, please link to the issue, if possible.

@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2022

Codecov Report

Merging #2385 (2a0d7b6) into master (19e518f) will decrease coverage by 0.03%.
The diff coverage is 98.36%.

@@            Coverage Diff             @@
##           master    #2385      +/-   ##
==========================================
- Coverage   98.71%   98.67%   -0.04%     
==========================================
  Files          73       72       -1     
  Lines        7771     7768       -3     
==========================================
- Hits         7671     7665       -6     
- Misses        100      103       +3     
Flag Coverage Δ
unittests 98.67% <98.36%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/default_styles.py 100.00% <ø> (ø)
rich/progress.py 92.76% <ø> (ø)
rich/segment.py 98.72% <93.10%> (+<0.01%) ⬆️
rich/_inspect.py 100.00% <100.00%> (ø)
rich/box.py 100.00% <100.00%> (ø)
rich/cells.py 96.05% <100.00%> (-3.95%) ⬇️
rich/console.py 98.30% <100.00%> (+0.01%) ⬆️
rich/highlighter.py 100.00% <100.00%> (ø)
rich/pretty.py 99.22% <100.00%> (+<0.01%) ⬆️
rich/style.py 99.75% <100.00%> (-0.01%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8767e86...2a0d7b6. Read the comment docs.

@willmcgugan willmcgugan merged commit 1de9471 into master Jul 11, 2022
@willmcgugan willmcgugan deleted the divide branch July 11, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants