Bump minimum Python version to 3.6.3 (from 3.6.1)
#2161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `OrderedDict[CacheKey, CacheValue]` code we use in the LRUCache class doesn't work with Python versions `3.6.1` and `3.6.2`, unfortunately
olivierphi
force-pushed
the
bump-minimum-version-to-3.6.3
branch
from
015914a
to
303e9b5
Compare
Codecov Report
@@ Coverage Diff @@
## master #2161 +/- ##
==========================================
- Coverage 99.46% 99.07% -0.40%
==========================================
Files 72 72
Lines 7339 7554 +215
==========================================
+ Hits 7300 7484 +184
- Misses 39 70 +31
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
OrderedDict[CacheKey, CacheValue]code we use in the LRUCache class doesn't work with Python versions3.6.1and3.6.2, unfortunately.Failed attempt to add more specific 3.6.3 check on GitHub Actions
I wanted to force a failing check with Python 3.6.2 and a successful one with 3.6.3 on GitHub Actions, but it turns out that we cannot since the oldest
3.6.xversion provided by these Actions is3.6.7, according to this file: 😔https://raw.githubusercontent.com/actions/python-versions/main/versions-manifest.json
Type of changes
Checklist