Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump typing extension #2157

Merged
merged 1 commit into from Apr 4, 2022
Merged

bump typing extension #2157

merged 1 commit into from Apr 4, 2022

Conversation

willmcgugan
Copy link
Collaborator

Fixes dependancy issue #2150

@codecov-commenter
Copy link

codecov-commenter commented Apr 4, 2022

Codecov Report

Merging #2157 (02c5bf1) into master (7105781) will decrease coverage by 0.39%.
The diff coverage is 85.77%.

@@            Coverage Diff             @@
##           master    #2157      +/-   ##
==========================================
- Coverage   99.46%   99.07%   -0.40%     
==========================================
  Files          72       72              
  Lines        7339     7554     +215     
==========================================
+ Hits         7300     7484     +184     
- Misses         39       70      +31     
Flag Coverage Δ
unittests 99.07% <85.77%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/__main__.py 100.00% <ø> (ø)
rich/layout.py 100.00% <ø> (ø)
rich/progress.py 93.51% <77.69%> (-4.92%) ⬇️
rich/console.py 99.21% <100.00%> (+0.06%) ⬆️
rich/terminal_theme.py 100.00% <100.00%> (ø)
rich/traceback.py 99.55% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 489fafc...02c5bf1. Read the comment docs.

@willmcgugan willmcgugan merged commit 9ab0758 into master Apr 4, 2022
@willmcgugan willmcgugan deleted the bump-typing-extensions branch April 4, 2022 10:45
@cschlittPHI
Copy link

Is there any way to bump the version number from this? We can't seem to use it as it uses the old version number still I think?

@willmcgugan
Copy link
Collaborator Author

New release coming soon

@willmcgugan
Copy link
Collaborator Author

@henryiii FYI we had to bump typing-extensions because the minimum version didn't have OrderedDict

@henryiii
Copy link
Contributor

henryiii commented Apr 5, 2022

That's annoying, very sorry! According to https://github.com/python/typing/tree/master/typing_extensions it was added in 3.7. They don't have a proper changelog until "4.0", so it can be hard to tell what's in typing_extensions, so I thought it was in typing_extensions 3.7 too. Looking at the history, it was added in 3.10.0 in python/typing@ea7f88e Please feel free to ping me if you need any help with anything related to what I've done.

In build we test all minimum versions too: https://github.com/pypa/build/blob/main/tests/constraints.txt (ironically, except for typing_extensions). I can set up a test like that if you want one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants