Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding indonesian translation for readme #2113

Merged
merged 4 commits into from Apr 4, 2022

Conversation

theDreamer911
Copy link
Contributor

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

I'm adding Indonesian translation for the readme section

@theDreamer911
Copy link
Contributor Author

I'm sorry I was a newbie in a pull request. The newest pull request has already been created. Thanks

@willmcgugan
Copy link
Collaborator

Your other PR doesn't have the README translation! I can merge both...

@willmcgugan willmcgugan reopened this Mar 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2022

Codecov Report

Merging #2113 (d31406d) into master (91e0146) will decrease coverage by 0.01%.
The diff coverage is 92.18%.

@@            Coverage Diff             @@
##           master    #2113      +/-   ##
==========================================
- Coverage   99.49%   99.48%   -0.02%     
==========================================
  Files          73       72       -1     
  Lines        7361     7335      -26     
==========================================
- Hits         7324     7297      -27     
- Misses         37       38       +1     
Flag Coverage Δ
unittests 99.48% <92.18%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/align.py 100.00% <ø> (ø)
rich/highlighter.py 100.00% <ø> (ø)
rich/layout.py 100.00% <ø> (ø)
rich/table.py 100.00% <ø> (ø)
rich/console.py 99.14% <82.14%> (-0.49%) ⬇️
rich/_win32_console.py 91.48% <100.00%> (+1.48%) ⬆️
rich/_windows_renderer.py 100.00% <100.00%> (ø)
rich/ansi.py 100.00% <100.00%> (ø)
rich/cells.py 100.00% <100.00%> (ø)
rich/control.py 100.00% <100.00%> (ø)
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d4ebb2...d31406d. Read the comment docs.

@theDreamer911
Copy link
Contributor Author

Thank you for merging it both Will

@theDreamer911 theDreamer911 mentioned this pull request Mar 26, 2022
9 tasks
@theDreamer911
Copy link
Contributor Author

Why the last check is failed @willmcgugan

@willmcgugan
Copy link
Collaborator

It's failing because Codespell only works for English text. You should find a codespell.yml in the github directory. If you add your translation to that, it should work...

Excluding ./README.it.md so the workflow test could be passed
@theDreamer911
Copy link
Contributor Author

Thanks, Will, I have already added the Indonesian inside codespell.yml but really sorry about changing the CHANGELOG.md by mistake

@willmcgugan willmcgugan merged commit ae1ee4e into Textualize:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants