Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typing: unify type hints for total keyword arguments in rich.progress #1131

Merged

Conversation

neutrinoceros
Copy link
Contributor

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • [NA] I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

I think this qualifies as a bug fix since the underlying object in all cases is rich.progress.Task, which is already documented as using a float total argument rather than an int.

@neutrinoceros neutrinoceros marked this pull request as draft March 24, 2021 15:56
@neutrinoceros
Copy link
Contributor Author

switching to draft until I manage to actually satisfy mypy

@neutrinoceros neutrinoceros force-pushed the type_annotations_progress_total branch from 2d908a5 to 4eac117 Compare March 24, 2021 15:58
@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #1131 (4eac117) into master (86a3844) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 4eac117 differs from pull request most recent head e08a838. Consider uploading reports for the commit e08a838 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1131      +/-   ##
==========================================
- Coverage   99.77%   99.76%   -0.01%     
==========================================
  Files          69       67       -2     
  Lines        6322     6074     -248     
==========================================
- Hits         6308     6060     -248     
  Misses         14       14              
Flag Coverage Δ
unittests 99.76% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rich/logging.py 100.00% <ø> (ø)
rich/progress_bar.py 100.00% <ø> (ø)
rich/_log_render.py 100.00% <100.00%> (ø)
rich/progress.py 97.05% <100.00%> (ø)
rich/table.py 99.72% <0.00%> (-0.01%) ⬇️
rich/bar.py 100.00% <0.00%> (ø)
rich/text.py 100.00% <0.00%> (ø)
rich/tree.py 100.00% <0.00%> (ø)
rich/align.py 100.00% <0.00%> (ø)
rich/pager.py 100.00% <0.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95016f4...e08a838. Read the comment docs.

@neutrinoceros neutrinoceros marked this pull request as ready for review March 24, 2021 16:10
@willmcgugan
Copy link
Collaborator

Thanks.

@willmcgugan willmcgugan merged commit d1f819a into Textualize:master Mar 25, 2021
@neutrinoceros neutrinoceros deleted the type_annotations_progress_total branch March 25, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants