[ELY-2078] Add encryption support to FileSystemSecurityRealm #1676

Ashpan · 2022-03-01T15:02:09Z

https://issues.redhat.com/browse/ELY-2078

fjuma · 2022-03-01T19:15:16Z

@Ashpan The fix for ELY-2249 has already been merged so that commit can be removed.

fjuma · 2022-03-01T19:25:32Z

auth/realm/base/src/main/java/org/wildfly/security/auth/realm/FileSystemRealmUtil.java

+ * @author <a href="mailto:araskar@redhat.com">Ashpan Raskar</a>
+ */
+public class FileSystemRealmUtil {
+    public static void createEncryptedRealmFromUnencrypted(FileSystemSecurityRealm unencryptedRealm, FileSystemSecurityRealm encryptedRealm) throws RealmUnavailableException {


Would be good to add javadoc for this method.

It would be good to add checks to make sure the params aren't null.

In addition to the variable descriptions, would be good to add a description of what the method does.

fjuma · 2022-03-01T19:51:40Z

auth/realm/base/src/main/java/org/wildfly/security/auth/realm/FileSystemSecurityRealm.java

@@ -855,7 +886,10 @@ private void writeIdentity(final XMLStreamWriter streamWriter, final LoadedIdent
                            String passwordString;
                            byte[] encoded = BasicPasswordSpecEncoding.encode(password, providers);

-                            if (encoded != null) {
+                            if (this.secretKey != null) {


A very minor comment but just wanted to mention for readability that it's not necessary to use this here or below.

fjuma · 2022-03-01T19:55:03Z

auth/realm/base/src/main/java/org/wildfly/security/auth/realm/FileSystemSecurityRealm.java

-                        streamWriter.writeAttribute("name", entry.getKey());
-                        streamWriter.writeAttribute("value", value);
+                            streamWriter.writeAttribute("name", this.secretKey != null ? CipherUtil.encrypt(entry.getKey(), this.secretKey) : entry.getKey());
+                            streamWriter.writeAttribute("value", this.secretKey != null ? CipherUtil.encrypt(value, this.secretKey) : value);


Looks like some extra indentation has been added here.

fjuma · 2022-03-01T19:56:28Z

auth/realm/base/src/main/java/org/wildfly/security/auth/realm/FileSystemSecurityRealm.java

@@ -1012,7 +1046,7 @@ private LoadedIdentity parseIdentityContents(final XMLStreamReader streamReader,
            }
            List<Credential> credentials = new ArrayList<>();
            do {
-                if (! version.getNamespace().equals(streamReader.getNamespaceURI())) {
+                if ( !(version.getNamespace().equals(streamReader.getNamespaceURI())) ) {


Looks like an extra set of brackets has been added here.

fjuma · 2022-03-01T20:04:14Z

auth/realm/base/src/main/java/org/wildfly/security/auth/realm/FileSystemSecurityRealm.java

+                            throw ElytronMessages.log.fileSystemRealmMissingAttribute("algorithm", path, streamReader.getLocation().getLineNumber(), name);
+                        }
+                        PasswordFactory passwordFactory = PasswordFactory.getInstance(algorithm);
+                        byte[] passwordByte = CodePointIterator.ofChars(text.toCharArray()).base64Decode().drain();


passwordBytes

fjuma · 2022-03-01T20:50:27Z

auth/realm/base/src/main/java/org/wildfly/security/auth/realm/FileSystemSecurityRealm.java

@@ -233,6 +247,8 @@ public FileSystemSecurityRealm(final Path root, final NameRewriter nameRewriter,
        this(root, nameRewriter, levels, true);
    }

+


Would be good to remove the extra white space in this file.

fjuma · 2022-03-01T20:56:30Z

auth/realm/base/src/main/java/org/wildfly/security/auth/realm/FileSystemRealmUtil.java

+     *
+     * @param unencryptedRealm the {@code FileSystemSecurityRealm} without any encryption applied
+     * @param encryptedRealm the {@code FileSystemSecurityRealm} configured with a SecretKey to encrypt identity data
+     * @throws RealmUnavailableException


@throws RealmUnavailableException if either realm is unavailable

fjuma · 2022-03-01T20:58:52Z

auth/realm/base/src/main/java/org/wildfly/security/auth/realm/FileSystemSecurityRealm.java

@@ -640,7 +696,7 @@ private Void createPrivileged() throws RealmUnavailableException {
                        streamWriter.writeCharacters("\n");
                        streamWriter.writeStartElement("identity");
                        // Continue to write using 1.0 as not using any features added in 1.0.1
-                        streamWriter.writeDefaultNamespace(ELYTRON_1_0);
+                        streamWriter.writeDefaultNamespace(Version.VERSION_1_0.getNamespace());


When secretKey is not null, we should be writing version 1.1.

The schema doesn't change when using an encrypted realm. Would this still require a Namespace bump?

Ah, are the schema changes only for the integrity portion of the changes? If so, ignore this.

Actually, was just thinking some more, the format value "enc_base64" is only allowed in the new 1.1 schema. This isn't a valid attribute for 1.0. So I think we should make the suggested changes.

fjuma · 2022-03-01T20:59:40Z

auth/realm/base/src/main/java/org/wildfly/security/auth/realm/FileSystemSecurityRealm.java

+        private Version requiredVersion(final LoadedIdentity identityToWrite) {
+            // As new functionality is added we will identify if we need to use a later version
+            // if new functionality is used then use the required schema version otherwise fallback
+            // to an older version.


If secretKey is not null, the required version should be 1.1.

fjuma · 2022-03-01T21:04:37Z

...realm/base/src/main/java/org/wildfly/security/auth/realm/FileSystemSecurityRealmBuilder.java

+    /**
+     * Set whether the identity name should be encoded for the filename in the realm.
+     *
+     * @param encoded whether identity names should be BASE32 encoded before using as filename if secretKey is not specified


encoded whether identity names should be BASE32 encoded before using as filename (only applies if the security realm is unencrypted)

fjuma · 2022-03-01T21:07:33Z

tool/src/main/java/org/wildfly/security/tool/ElytronTool.java

 import java.security.Security;
 import java.util.HashMap;
 import java.util.Map;
+import org.apache.commons.cli.AlreadySelectedException;


It's better to not re-order imports.

fjuma · 2022-03-01T21:07:50Z

tool/src/main/java/org/wildfly/security/tool/ElytronToolMessages.java

@@ -27,11 +31,6 @@
 import org.jboss.logging.annotations.Message;
 import org.jboss.logging.annotations.MessageLogger;

-import java.io.FileNotFoundException;


fjuma · 2022-03-01T21:18:32Z

auth/realm/base/src/main/java/org/wildfly/security/auth/realm/FileSystemSecurityRealm.java

@@ -234,8 +233,6 @@ public FileSystemSecurityRealm(final Path root, final NameRewriter nameRewriter,
        this(root, nameRewriter, levels, encoded, Encoding.BASE64, StandardCharsets.UTF_8, INSTALLED_PROVIDERS, null);
    }

-


It would be good to remove the white space changes.

fjuma · 2022-03-01T21:42:10Z

tool/src/main/java/org/wildfly/security/tool/FileSystemEncryptRealmCommand.java

+import org.wildfly.security.password.spec.Encoding;
+
+/**
+ * Elytron-Tool command to convert un-encrypted FileSystemRealms into an encrypted realm with the use of a SecreKey.


s/SecreKey/SecretKey

fjuma · 2022-03-01T21:46:01Z

tool/src/main/java/org/wildfly/security/tool/FileSystemEncryptRealmCommand.java

+
+class FileSystemEncryptRealmCommand extends Command {
+    static final int GENERAL_CONFIGURATION_WARNING = 1;
+    static final String FILE_SYSTEM_ENCRYPT_COMMAND = "filesystem-encrypt";


Might be good to include realm in the name, e.g., filesystem-realm-encrypt

fjuma · 2022-03-01T21:51:41Z

tool/src/main/java/org/wildfly/security/tool/FileSystemEncryptRealmCommand.java

+                try {
+                    descriptor.setHashCharset(Charset.forName(hashCharsetOption));
+                } catch (UnsupportedCharsetException e) {
+//                    Error


Just wondering if something went wrong when updating your commits. I think I had previously added a comment about updating the error handling in this file but I don't see those changes here.

I think I lost those changes in the rebasing, fetching those changes from the original PR

fjuma · 2022-03-01T21:53:34Z

tool/src/main/java/org/wildfly/security/tool/FileSystemEncryptRealmCommand.java

+                    .setRoot(Paths.get(descriptor.getOutputRealmLocation(), descriptor.getFileSystemRealmName()))
+                    .setSecretKey(key)
+                    .setLevels(descriptor.getLevels())
+                    .setHashEncoding(descriptor.getHashEncoding())


Does the encrypted realm actually make use of the hashEncoding?

Good catch it doesn't, I'll remove that

fjuma · 2022-03-01T21:58:27Z

tool/src/main/java/org/wildfly/security/tool/FileSystemEncryptRealmCommand.java

+                continue;
+            }
+            CredentialStore credentialStore;
+            if ((descriptor.getCredentialStore() == null) == (descriptor.getSecretKeyAlias() == null)) {


Is this suppose to be && instead of == here?

I did the == here to check if either both are not null or both are null.
If only 1 is defined but not the other, and error is thrown: https://github.com/wildfly-security/wildfly-elytron/pull/1676/files/b1443435ea996fc76917a3bd58c7f14852c30819#diff-ebe53241afd70e1e5743d6db5b39150461c335abce6c083cafbf6aae4b4c1e2dR650

I could also check with an ^ XOR operator

fjuma · 2022-03-01T22:44:22Z

tests/base/src/test/java/org/wildfly/security/auth/FileSystemSecurityRealmTest.java

+                .setSecretKey(key)
+                .build();
+        ModifiableRealmIdentity identity = securityRealm.getRealmIdentityForUpdate(new NamePrincipal("plainUser"));
+


Should there be a check to make sure the identity doesn't exist here before the call to create?

Ashpan · 2022-03-15T23:27:21Z

@fjuma @Skyllarr All comments have been addressed now

OndrejKotek · 2022-03-16T14:41:26Z

tool/src/main/java/org/wildfly/security/tool/FileSystemEncryptRealmCommand.java

+
+            Descriptor descriptor = new Descriptor();
+            descriptor.setFileSystemRealmName(realmNameOption);
+            descriptor.setOutputRealmLocation(Paths.get(outputRealmLocationOption).toString());


When outputRealmLocationOption is not set NullPointerException is thrown

$ ./bin/elytron-tool.sh filesystem-realm-encrypt -i a --debug Exception encountered executing the command: java.lang.NullPointerException at java.base/sun.nio.fs.UnixPath.normalizeAndCheck(UnixPath.java:75) at java.base/sun.nio.fs.UnixPath.<init>(UnixPath.java:69) at java.base/sun.nio.fs.UnixFileSystem.getPath(UnixFileSystem.java:279) at java.base/java.nio.file.Path.of(Path.java:147) at java.base/java.nio.file.Paths.get(Paths.java:69) at org.wildfly.security.elytron-tool@1.18.4.CR1-SNAPSHOT//org.wildfly.security.tool.FileSystemEncryptRealmCommand.execute(FileSystemEncryptRealmCommand.java:325) at org.wildfly.security.elytron-tool@1.18.4.CR1-SNAPSHOT//org.wildfly.security.tool.ElytronTool.main(ElytronTool.java:85) at org.jboss.modules.Module.run(Module.java:353) at org.jboss.modules.Module.run(Module.java:321) at org.jboss.modules.Main.main(Main.java:604)

Changed to

Exception encountered executing the command: org.apache.commons.cli.MissingArgumentException: Output Realm location not specified. at org.wildfly.security.tool.FileSystemEncryptRealmCommand.execute(FileSystemEncryptRealmCommand.java:326) at org.wildfly.security.tool.ElytronTool.main(ElytronTool.java:85)

OndrejKotek · 2022-03-16T14:42:38Z

tool/src/main/java/org/wildfly/security/tool/FileSystemEncryptRealmCommand.java

+            Descriptor descriptor = new Descriptor();
+            descriptor.setFileSystemRealmName(realmNameOption);
+            descriptor.setOutputRealmLocation(Paths.get(outputRealmLocationOption).toString());
+            descriptor.setInputRealmLocation(Paths.get(inputRealmLocationOption).toString());


The same as for the previous line.

Changed to

Exception encountered executing the command: org.apache.commons.cli.MissingArgumentException: Input Realm location not specified. at org.wildfly.security.tool.FileSystemEncryptRealmCommand.execute(FileSystemEncryptRealmCommand.java:331) at org.wildfly.security.tool.ElytronTool.main(ElytronTool.java:85)

OndrejKotek · 2022-03-16T15:02:31Z

tool/src/main/java/org/wildfly/security/tool/FileSystemEncryptRealmCommand.java

+            );
+
+            if (!createScriptCheck.equals("y") && !createScriptCheck.equals("yes")) {
+                Files.write(Paths.get(String.format("%s/%s.sh", outputRealmLocation, fileSystemRealmName)), scriptLines, StandardOpenOption.CREATE, StandardOpenOption.TRUNCATE_EXISTING);


When the outputRealmLocation directory does not exist, this results into NoSuchFileException:

$ ./bin/elytron-tool.sh filesystem-realm-encrypt -i fs-realm-users-plain -o fs-realm-users-plain-enc --debug Creating encrypted realm for: fs-realm-users-plain Exception encountered executing the command: java.nio.file.NoSuchFileException: fs-realm-users-plain-enc/encrypted-filesystem-realm.sh at java.base/sun.nio.fs.UnixException.translateToIOException(UnixException.java:92) at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:111) at java.base/sun.nio.fs.UnixException.rethrowAsIOException(UnixException.java:116) at java.base/sun.nio.fs.UnixFileSystemProvider.newByteChannel(UnixFileSystemProvider.java:219) at java.base/java.nio.file.spi.FileSystemProvider.newOutputStream(FileSystemProvider.java:478) at java.base/java.nio.file.Files.newOutputStream(Files.java:220) at java.base/java.nio.file.Files.write(Files.java:3490) at java.base/java.nio.file.Files.write(Files.java:3541) at org.wildfly.security.elytron-tool@1.18.4.CR1-SNAPSHOT//org.wildfly.security.tool.FileSystemEncryptRealmCommand.createWildFlyScript(FileSystemEncryptRealmCommand.java:753) at org.wildfly.security.elytron-tool@1.18.4.CR1-SNAPSHOT//org.wildfly.security.tool.FileSystemEncryptRealmCommand.execute(FileSystemEncryptRealmCommand.java:388) at org.wildfly.security.elytron-tool@1.18.4.CR1-SNAPSHOT//org.wildfly.security.tool.ElytronTool.main(ElytronTool.java:85) at org.jboss.modules.Module.run(Module.java:353) at org.jboss.modules.Module.run(Module.java:321) at org.jboss.modules.Main.main(Main.java:604)

Changed to now create outputRealmLocation directory if it does not exist
https://github.com/wildfly-security/wildfly-elytron/pull/1676/files#diff-ebe53241afd70e1e5743d6db5b39150461c335abce6c083cafbf6aae4b4c1e2dR329-R332

OndrejKotek · 2022-03-16T15:03:46Z

tool/src/main/java/org/wildfly/security/tool/FileSystemEncryptRealmCommand.java

+            );
+
+            if (!createScriptCheck.equals("y") && !createScriptCheck.equals("yes")) {
+                Files.write(Paths.get(String.format("%s/%s.sh", outputRealmLocation, fileSystemRealmName)), scriptLines, StandardOpenOption.CREATE, StandardOpenOption.TRUNCATE_EXISTING);


Why .sh? It's not a shell script. Something like .cli would be more descriptive.

I was using the same implementation used in the FileSystemRealmCommand.java.
I can change it to .cli instead

OndrejKotek · 2022-03-16T15:39:27Z

tool/src/main/java/org/wildfly/security/tool/FileSystemEncryptRealmCommand.java

+            } else {
+                descriptor.setSecretKeyAlias("key");
+            }
+            descriptors.add(descriptor);


findMissingRequiredValuesAndSetValues is not applied in this case, hence it's not clear what is missing. For example the following ends with no identities converted (silently skipped by the initial check in createFileSystemRealm?)

$ ./bin/elytron-tool.sh filesystem-realm-encrypt -i ./standalone/configuration/fs-realm-users-plain -o ./standalone/configuration/fs-realm-users-plain-enc --debug Creating encrypted realm for: ./standalone/configuration/fs-realm-users-plain

Added a warning message to indicate something is missing. Although now it should flag it before entering that method

https://github.com/wildfly-security/wildfly-elytron/pull/1676/files#diff-ebe53241afd70e1e5743d6db5b39150461c335abce6c083cafbf6aae4b4c1e2dR664-R666

fjuma · 2022-03-16T17:16:53Z

tool/src/main/java/org/wildfly/security/tool/ElytronToolMessages.java

+    @Message(id = NONE, value = "Bulk conversion with options listed in description file. Optional options have default values, required options do not. (Action) %n" +
+            "The options realm-name, hash-encoding, levels, secret-key, and populate are optional. %n" +
+            "The default values of realm-name, hash-charset, hash-encoding, levels, and create are encrypted-filesystem-realm, BASE64, UTF-8, 2, and true respectively. %n" +
+            "Values are required for the following options: input-location, output-location, and credential-store. %n" +


Would be good to move the information about required values to the beginning.

fjuma · 2022-03-16T17:18:23Z

tool/src/main/java/org/wildfly/security/tool/ElytronToolMessages.java

@@ -422,6 +467,25 @@
            "Blocks of options must be separated by a blank line.")
    String cmdFileSystemRealmBulkConvertDesc();

+    @Message(id = NONE, value = "Bulk conversion with options listed in description file. Optional options have default values, required options do not. (Action) %n" +
+            "The options realm-name, hash-encoding, levels, secret-key, and populate are optional. %n" +
+            "The default values of realm-name, hash-charset, hash-encoding, levels, and create are encrypted-filesystem-realm, BASE64, UTF-8, 2, and true respectively. %n" +


hash-charset and UTF-8 should be removed from the description here

secret-key and its default value should be added here

the previous line mentions "populate" but this line mentions "create", this needs to be sorted out

fjuma · 2022-03-16T17:27:52Z

tool/src/main/java/org/wildfly/security/tool/FileSystemEncryptRealmCommand.java

+                descriptor.setSecretKeyAlias("key");
+            }
+            descriptors.add(descriptor);
+        } else if (realmNameOption != null | inputRealmLocationOption != null |


Looks like this else if needs to cover all the options right? I think some are missing here.

Aren't we still missing options like hashEncoding, levels, etc.? IIUC, we get here if the bulk option is being used so any specified option should result in an error, right?

fjuma · 2022-03-16T17:53:53Z

tool/src/main/java/org/wildfly/security/tool/FileSystemEncryptRealmCommand.java

+     */
+    private void createFileSystemRealm() throws Exception {
+        for (Descriptor descriptor : descriptors) {
+            System.out.println("Creating encrypted realm for: " + descriptor.getInputRealmLocation());


This message should be in the messages file.

fjuma · 2022-03-16T18:00:12Z

tool/src/test/java/org/wildfly/security/tool/FileSystemEncryptRealmCommandTest.java

+        }
+    }
+
+    @Test


Would be good to test the case where one or more required attributes is missing both in bulk mode and regular mode.

Added tests for both, testSingleUserMissingParam, testBulkMissingParam

fjuma · 2022-03-16T21:51:26Z

tool/src/main/java/org/wildfly/security/tool/FileSystemEncryptRealmCommand.java

+    private static final class Descriptor {
+        private String inputRealmLocation;
+        private String outputRealmLocation;
+        private String FileSystemRealmName;


should be fileSystemRealmName

fjuma · 2022-03-16T21:53:07Z

tool/src/main/java/org/wildfly/security/tool/FileSystemEncryptRealmCommand.java

+                descriptor.setSecretKeyAlias("key");
+            }
+            descriptors.add(descriptor);
+        } else if (realmNameOption != null | inputRealmLocationOption != null |


Aren't we still missing options like hashEncoding, levels, etc.? IIUC, we get here if the bulk option is being used so any specified option should result in an error, right?

…alm. This new schema drops all elements and types specific to authentication client. Additionally prepare for support for new items to be added to this namespace.

fjuma · 2022-03-17T18:32:22Z

tool/src/main/java/org/wildfly/security/tool/FileSystemEncryptRealmCommand.java

+            checkDescriptorFields(descriptor);
+        } else if (inputRealmLocationOption != null | outputRealmLocationOption != null |
+                realmNameOption != null | credentialStoreOption != null | createCredentialStore != null |
+                secretKeyAliasOption != null | hashEncodingOption != null | levelsOption != null | populateOption != null) {


I think encodedOption is the last one needed here.

fjuma · 2022-03-17T22:05:17Z

@Ashpan Just one last small thing. The fourth commit message refers to logging specifically but there are a lot of other changes in that commit too so would be good to reword it to make it more general.

Skyllarr · 2022-03-18T12:42:59Z

@Ashpan Just one last small thing. The fourth commit message refers to logging specifically but there are a lot of other changes in that commit too so would be good to reword it to make it more general.

@Ashpan There are also some tool's command changes in that logging commit which could be moved to a previous commit regarding elytron tool. But that is just minor it is ok to merge like this

…nd general code cleanup

This was referenced Mar 1, 2022

[WFCORE-5530] Add encryption support to FilesystemSecurityRealm wildfly/wildfly-core#4983

Merged

[ELY-2078] Add encryption and integrity support to FileSystemSecurityRealm #1567

Closed

fjuma changed the title ~~[ELY-2078] Add encryption and integrity support to FileSystemSecurityRealm~~ [ELY-2078] Add encryption support to FileSystemSecurityRealm Mar 1, 2022

Ashpan force-pushed the ELY-2078-encryption branch 2 times, most recently from 2e611f4 to a8d221b Compare March 1, 2022 19:05

fjuma reviewed Mar 1, 2022

View reviewed changes

Ashpan force-pushed the ELY-2078-encryption branch from a8d221b to e4e2a5d Compare March 1, 2022 19:49

fjuma reviewed Mar 1, 2022

View reviewed changes

Ashpan force-pushed the ELY-2078-encryption branch 2 times, most recently from b7e984a to 4e56cda Compare March 1, 2022 20:43

fjuma reviewed Mar 1, 2022

View reviewed changes

Ashpan force-pushed the ELY-2078-encryption branch 2 times, most recently from 5ec1520 to b144343 Compare March 1, 2022 21:03

fjuma reviewed Mar 1, 2022

View reviewed changes

Ashpan force-pushed the ELY-2078-encryption branch from 29c14ab to b744e95 Compare March 15, 2022 23:25

OndrejKotek reviewed Mar 16, 2022

View reviewed changes

Ashpan force-pushed the ELY-2078-encryption branch 2 times, most recently from 46a19d5 to 7885747 Compare March 16, 2022 16:16

fjuma reviewed Mar 16, 2022

View reviewed changes

Ashpan force-pushed the ELY-2078-encryption branch 3 times, most recently from a4c9cc0 to e284dbd Compare March 16, 2022 20:40

fjuma reviewed Mar 16, 2022

View reviewed changes

Ashpan force-pushed the ELY-2078-encryption branch from e284dbd to 0dffe2c Compare March 17, 2022 13:56

[ELY-2241] Bump to a new version 1.1 namespace for the fileysystem re…

310dc3c

…alm. This new schema drops all elements and types specific to authentication client. Additionally prepare for support for new items to be added to this namespace.

Ashpan force-pushed the ELY-2078-encryption branch from 0dffe2c to 02ed489 Compare March 17, 2022 17:59

fjuma reviewed Mar 17, 2022

View reviewed changes

Ashpan force-pushed the ELY-2078-encryption branch from 02ed489 to 9672942 Compare March 17, 2022 20:28

[ELY-2078] Add encryption support to FileSystemSecurityRealm

22bb7be

Ashpan force-pushed the ELY-2078-encryption branch from 9672942 to e9db9f5 Compare March 17, 2022 20:59

Skyllarr approved these changes Mar 18, 2022

View reviewed changes

Ashpan force-pushed the ELY-2078-encryption branch from e9db9f5 to 7135ccc Compare March 18, 2022 13:41

Ashpan added 2 commits March 18, 2022 10:24

[ELY-2078] Elytron tool to encrypted a filesystem realm

9710c35

[ELY-2078] Added logging for accessing realm with invalid SecretKey a…

7050f15

…nd general code cleanup

Ashpan force-pushed the ELY-2078-encryption branch from 7135ccc to 7050f15 Compare March 18, 2022 14:24

fjuma merged commit 6996cb6 into wildfly-security:1.x Mar 18, 2022

cam-rod mentioned this pull request Apr 19, 2023

[ELY-2496] Add integrity to existing filesystem realms using Elytron Tool #1896

Merged

		@@ -233,6 +247,8 @@ public FileSystemSecurityRealm(final Path root, final NameRewriter nameRewriter,
		this(root, nameRewriter, levels, true);
		}

		@@ -234,8 +233,6 @@ public FileSystemSecurityRealm(final Path root, final NameRewriter nameRewriter,
		this(root, nameRewriter, levels, encoded, Encoding.BASE64, StandardCharsets.UTF_8, INSTALLED_PROVIDERS, null);
		}

+                      }
+                  }
+                  @Test

[ELY-2078] Add encryption support to FileSystemSecurityRealm #1676

[ELY-2078] Add encryption support to FileSystemSecurityRealm #1676

Conversation

Ashpan commented Mar 1, 2022

fjuma commented Mar 1, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fjuma Mar 1, 2022 • edited

Choose a reason for hiding this comment

Ashpan Mar 1, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ashpan commented Mar 15, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ashpan Mar 16, 2022 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fjuma commented Mar 17, 2022

Skyllarr commented Mar 18, 2022 • edited

fjuma Mar 1, 2022 •

edited

Ashpan Mar 1, 2022 •

edited

Ashpan Mar 16, 2022 •

edited

Skyllarr commented Mar 18, 2022 •

edited