[ELY-2295] Algorithm alias "Data" generates errors in WFCORE test-suite with jdk-18 #1667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any possibility this could get it into next Elytron release @fjuma ? It is the last issue in Elytron area WRT WildFly on JDK18 EA. |
|
@ropalka Yes. When do you need this fix by? |
|
There's no hurry @fjuma , next Elytron release according to your plan is fine :) |
|
When is the next Elytron release planned @fjuma ? I had a quick chat with Brian, we want to backport JDK18 support to WildFly 26.x branch and this is the last remaining issue to pass WildFly upstream test suite. |
|
@ropalka I'm planning on including this one in the Elytron tag this week for WildFly 26.1. |
fjuma
approved these changes
Mar 16, 2022
|
@Skyllarr Please review and merge when you get a chance. Thanks! |
Skyllarr
approved these changes
Mar 17, 2022
|
@rmartinc Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://issues.redhat.com/browse/ELY-2295
Just removing the alias
Datathat was added using the legacy method. It is discarded by the jdk now (no real legacy service associated), so it is invalid and useless. With jdk-18 build 28 the alias generates failures in the wfcore test-suite.The test
KeyStoreCredentialStoreTestis also modified to test the PKCS12 credential key store with more jdk implementations (in version 11 it works for all of them, openjdk, zulu, openj9, ibm,... So better discard the ones we know that fail instead of only allowing the oracle vendor).