From 5b2ac6432f3a7a0ba8551c14474e6c0495f88864 Mon Sep 17 00:00:00 2001
From: Antoine Musso <hashar@free.fr>
Date: Mon, 26 Feb 2018 18:56:03 +0100
Subject: [PATCH] Set npm version for frontend-maven-plugin

When using NodeJS 4+, the frontend-maven-plugin uses the bundled npm,
but it ends up not being available via PATH lookup. That causes issue
when one package.json has a script that invokes npm (it can not be
found).

Set <npmVersion> to the version being used on Wikimedia CI which would
hopefully install npm in a directory belonging to PATH.

https://github.com/eirslett/frontend-maven-plugin/issues/560
https://github.com/eirslett/frontend-maven-plugin#installing-node-and-npm

Bug: T188285
Change-Id: Ia892dcfdc1c0ef055f00a493941e974198323012
---
 pom.xml | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/pom.xml b/pom.xml
index 36d6ca47..decb145b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -758,6 +758,15 @@
                     <groupId>com.github.eirslett</groupId>
                     <artifactId>frontend-maven-plugin</artifactId>
                     <version>1.6</version>
+                    <configuration>
+                        <!--
+                             npm installed from NodeJS distribution turns out
+                             to not be in PATH which has side effects.
+                             https://phabricator.wikimedia.org/T188285
+                             https://github.com/eirslett/frontend-maven-plugin/issues/560
+                        -->
+                        <npmVersion>3.8.3</npmVersion>
+                    </configuration>
                 </plugin>
                 <plugin>
                     <groupId>org.apache.maven.plugins</groupId>