Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "unit-disallowed-list": "%" to config #98

Open
Volker-E opened this issue Aug 7, 2019 · 4 comments
Open

Add "unit-disallowed-list": "%" to config #98

Volker-E opened this issue Aug 7, 2019 · 4 comments
Assignees

Comments

@Volker-E
Copy link
Contributor

Volker-E commented Aug 7, 2019

Consider settling on ems only for relative font-sizing, not ending up with using both. We could also add ex to disallowed list in same activity.

@Volker-E Volker-E changed the title a Add "unit-blacklist": "%" to config Aug 7, 2019
@jdforrester
Copy link
Member

I'm also OK with this.

@Volker-E
Copy link
Contributor Author

"unit-blacklist": [
	"%",
	"rem"
]

is not a universal solution with box-sizing properties needing to feature %. It should be considered to be added in a follow-up to #105 for font-size instead.

@Volker-E Volker-E changed the title Add "unit-blacklist": "%" to config Add "unit-disallowed-list": "%" to config Apr 20, 2022
@jdlrobson
Copy link
Member

Does this issue include adding support for rems? If not, I'll open a new ticket, but we're likely be used rems soon as part o the font-size changes in Vector 2022 (https://phabricator.wikimedia.org/T261334.)

@jdforrester
Copy link
Member

Does this issue include adding support for rems? If not, I'll open a new ticket, but we're likely be used rems soon as part o the font-size changes in Vector 2022 (https://phabricator.wikimedia.org/T261334.)

Let's do that as a related task; this one needs re-thinking, as adding % directly to unit-disallowed-list will break color: lighten( #fc0, 50% ); (from our test suite).

jdforrester added a commit that referenced this issue Jul 11, 2023
We no longer support browsers that don't understand rems at all.

Related to #98
jdlrobson pushed a commit that referenced this issue Jul 11, 2023
…215)

We no longer support browsers that don't understand rems at all.

Related to #98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

6 participants