Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] build: Upgrade to Stylelint 16 #227

Closed
wants to merge 1 commit into from

Conversation

Volker-E
Copy link
Contributor

@Volker-E Volker-E commented Jan 30, 2024

Also

  • changing to '@stylistic/stylelint-plugin' as 'stylelint-stylistic' isn't compatible with Stylelint 16 anymore
  • removing Node 16 from the CI as it's not supported by Stylelint 16

Fixes #225

Also
- changing to '@stylistic/stylelint-plugin' as 'stylelint-stylistic'
  isn't compatible with Stylelint 16 anymore
- removing Node 16 from the CI as it's not supported by Stylelint 16

Fixes wikimedia#10
@jdforrester
Copy link
Member

Yeah, I ran into big issues with this via grunt-stylelint (see wikimedia/grunt-stylelint#126). :-(

Also #10 is a closed MR, not an issue this can be fixing.

@Volker-E
Copy link
Contributor Author

The tests are failing right now on a number of stylistic rules, but also other non-changed ones to not be covered in invalid fixtures. Also I think I've unintended kicked test/fixtures/default/invalid.windows.css Windows line-break out currently. Help welcome for failing tests!

@Volker-E
Copy link
Contributor Author

Yeah, I ran into big issues with this via grunt-stylelint (see wikimedia/grunt-stylelint#126). :-(

Also #10 is a closed MR, not an issue this can be fixing.

Whoops, the 10th issue, number #225

@jdforrester
Copy link
Member

Forked to #229 as I needed to make some tweaks. :-(

@jdforrester jdforrester closed this May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

The stylelint-stylistic package has been deprecated
2 participants