Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flag setting height in px values #131

Open
Volker-E opened this issue Dec 21, 2020 · 3 comments
Open

Flag setting height in px values #131

Volker-E opened this issue Dec 21, 2020 · 3 comments

Comments

@Volker-E
Copy link
Contributor

That's an accessibility anti-pattern. For example when user overrides text default size. And should only be allowed with disable line. Latest initiation was https://gerrit.wikimedia.org/r/c/wvui/+/651245

@Volker-E
Copy link
Contributor Author

Similar concern as in #104.

@jdforrester
Copy link
Member

There are an awful lot of hits for setting height in pixels: https://codesearch-beta.wmcloud.org/deployed/?q=height%3A+%5Cd%2Bpx&excludeFiles=lib

Do we want to do a series of fixes first, or are all ~1000 of those hits going to have to be annotated?

@edg2s
Copy link
Member

edg2s commented Jun 27, 2023

Some valid exceptions from that list:

  • height:1px hacks
  • setting the same height as fixed size image, where it is known there is plenty of space for the text

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants