Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.20.0 #376

Merged
merged 1 commit into from
Apr 7, 2021
Merged

Release v0.20.0 #376

merged 1 commit into from
Apr 7, 2021

Conversation

edg2s
Copy link
Member

@edg2s edg2s commented Apr 7, 2021

No description provided.

@edg2s
Copy link
Member Author

edg2s commented Apr 7, 2021

Merge after #375

@jdforrester
Copy link
Member

Do we want to pull in the new eslint-plugin-no-jquery first?

@jdforrester
Copy link
Member

Not before #377.

jdforrester
jdforrester requested changes Apr 7, 2021
View reviewed changes
Copy link
Member

@jdforrester jdforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to mention the jquery change.

(Also, should we replicate the upstream things like "Rule fix: Add fixer for no-on-ready"?)

@edg2s
Copy link
Member Author

edg2s commented Apr 7, 2021

(Also, should we replicate the upstream things like "Rule fix: Add fixer for no-on-ready"?)

I haven't done in the past. Unless it's significant, in which case it could be mentioned in the library update commit.

jdforrester
jdforrester approved these changes Apr 7, 2021
View reviewed changes
Copy link
Member

@jdforrester jdforrester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack.

@jdforrester jdforrester merged commit 4ff99ae into master Apr 7, 2021
@jdforrester jdforrester deleted the v0.20.0 branch April 7, 2021 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdforrester jdforrester jdforrester approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edg2s @jdforrester