Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to SvelteKit 1.0 and remove old workarounds #10

Closed
benmccann opened this issue Jan 24, 2023 · 3 comments
Closed

Upgrade to SvelteKit 1.0 and remove old workarounds #10

benmccann opened this issue Jan 24, 2023 · 3 comments

Comments

@benmccann
Copy link

There are four issues referred to on the readme currently. Issues 2-4 have been closed. The first part of issue 1 has been addressed as well (output is now relative). It'd be nice to see what still needs to be addressed so that we can close the gap in SvelteKit. After it's been updated we can possibly add the dynamic base path support to SvelteKit, which is probably the last thing that's needed.

@wighawag
Copy link
Owner

After investigation, svelte-kit still need some update to support IPFS
See comment here : sveltejs/kit#595 (comment)

And here is a reproduction repo showing the issues : https://github.com/bug-reproduction/svelte-kit-static-ipfs

I could try to update sveltejs-adapter-ipfs but ideally it should be handled by svelte-kit itself

IPFS is after all just a static server and the only constraint is that the website should support dynamic basepath, which svelte-kit should support as discussed here : sveltejs/kit#595

This not only for IPFS but for situation where it is not possible to know where the website will be hosted (archive website, etc...)

@wighawag
Copy link
Owner

@benmccann

I spent some more time on it and it should now be working with sveltekit 1.0

It is available in v0.4.5

It is not full proof though and it only serve as documentation to have this properly fix in sveltekit

The process have been documented in the README but a more detailed explanation can be found in this repo/branch : https://github.com/bug-reproduction/svelte-kit-static-ipfs/tree/fixes#fixes

@benmccann
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants