Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom SVG attributes #113

Merged
merged 1 commit into from May 6, 2021
Merged

Add custom SVG attributes #113

merged 1 commit into from May 6, 2021

Conversation

whomwah
Copy link
Owner

@whomwah whomwah commented Apr 22, 2021 •
edited

Thanks to @mjy and #99

Add the ability to pass in custom SVG attributes to be used in the <svg> tag. This is not smart, so it you use an attribute that is already set, you will just end up with two.

RQRCode::QRCode.new("qrcode").as_svg(svg_attributes: {class: "myKlass"})

=> <svg ... width="231" height="231" shape-rendering="crispEdges" class="myKlass"/>...

@whomwah whomwah self-assigned this Apr 22, 2021
@whomwah whomwah changed the base branch from master to dr-release-2.0.0 April 22, 2021 15:09
@whomwah whomwah changed the base branch from dr-release-2.0.0 to master April 23, 2021 13:28
@whomwah
feat: Add custom SVG attributes
8ae141b 
Thanks to @mjy and #99 for the initial work
@whomwah whomwah merged commit 67785b4 into master May 6, 2021
@whomwah whomwah deleted the dr-attributes branch May 6, 2021 09:33
@whomwah whomwah mentioned this pull request May 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@whomwah whomwah

Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@whomwah