- dedenter.rb: Fix squiggly heredoc line continuation handling #819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstly, this fixes an issue with non-interpolating squiggly heredocs, where line continuation characters should be ignored. Two things were broken: - The line continuation backslash would be removed, as well as the subsequent carriage return - The subsequent line would not be dedented. For example, the following source: <<~'END' foo \ bar END Would be parsed as follows: (dstr (str "foo ") (str " bar\n")) With the change, the result is: (dstr (str "foo \\\n") (str "bar\n")) This also fixes an issue with interpolating squiggly heredocs, where an escaped backslash followed by a newline would be interpreted as a line continuation. In that case, the following source: <<~END foo \\ bar END Would (again) be parsed as follows: (dstr (str "foo ") (str " bar\n")) With the change, the result is: (dstr (str "foo \\\n") (str "bar\n"))
iliabylich
changed the title
|
@mvz Thanks! |
mvz
deleted the
fix-non-interpolating-squiggly-heredoc-interpolation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, this fixes an issue with non-interpolating squiggly heredocs, where line continuation characters should be ignored. Two things were broken:
For example, the following source:
Would be parsed as follows:
With the change, the result is:
This also fixes an issue with interpolating squiggly heredocs, where an escaped backslash followed by a newline would be interpreted as a line continuation. This is issue #789.
In that case, the following source:
Would (again) be parsed as follows:
With the change, the result is: