Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ ruby31.y: allow "command" syntax in endless method definition #801

Conversation

koic
Copy link
Collaborator

@koic koic commented May 13, 2021

Fixes #799.

@iliabylich
Copy link
Collaborator

@koic could you also backport tests for command kRESCUE_MOD arg cases please? I'm talking about these guys.

Also this new syntax is a pure hack, def foo = bar baz is a command assignment that is reduced in a different way 🔥

@koic koic force-pushed the allow_command_syntax_in_endless_method_definition branch from ae02bd9 to 729bc63 Compare May 14, 2021 02:17
@koic
Copy link
Collaborator Author

koic commented May 14, 2021

Thank you for your review. I've added missing backporting tests.

Copy link
Collaborator

@iliabylich iliabylich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iliabylich iliabylich merged commit 7ecddb6 into whitequark:master May 14, 2021
@iliabylich
Copy link
Collaborator

@koic thanks!

@koic koic deleted the allow_command_syntax_in_endless_method_definition branch May 14, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ruby/ruby@31794d2
2 participants