New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ship grammar files #749
Comments
@kddeisz I think that, given the Instead we should make a 2nd gem I'm not authoritative here, if the maintainer (@iliabylich) thinks its too much work to have a split gem. I'd support to bring the |
Oof, looks like you rewrite grammar rules on the fly. Are you able to use git repo? You'll need to have ragel too, I'm not super opinionated on adding these files back, but it just feels awkward to rely on private API. It sounds similar to re-using gem's test suite "because you can". |
Yeah it's not widely used and I'm mostly maintaining it for posterity/interest. Honestly I think I'm cool just retiring it. I was thinking if you maybe wanted to ship them then that would be fine but if it's going to cause extra effort I'd rather just archive the project. Thanks for your work! |
Hi! 馃憢
First of all, I'm sorry about this issue. I am very much reminded of
A recent PR (#745) changed the files that get shipped with this gem. Believe it or not, I was actually relying on the
.y
files shipped with this gem for my own project (https://github.com/kddeisz/vernacular-ast). You can see the failure here (https://github.com/kddeisz/vernacular-ast/pull/83/checks?check_run_id=1218675563#step:8:6) because the.y
files are no longer shipped.Any chance I could get them back?
The text was updated successfully, but these errors were encountered: