Drop git in gemspec
#745
Merged
Drop git in gemspec
#745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliabylich
reviewed
Sep 25, 2020
utkarsh2102
force-pushed
the
drop-git-in-gemspec
branch
from
11be2b5
to
8b0a22c
Compare
iliabylich
requested changes
Sep 25, 2020
utkarsh2102
force-pushed
the
drop-git-in-gemspec
branch
2 times, most recently
from
36c1ff0
to
4d92a6c
Compare
|
@utkarsh2102 my bad, should be |
Using `git` in gemspec, in general, is problematic. cf: https://docs.rubocop.org/rubocop-packaging/cops_packaging.html#gemspec-git-rationale Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
utkarsh2102
force-pushed
the
drop-git-in-gemspec
branch
from
4d92a6c
to
9008df7
Compare
I've taken all together at once now. Should be good to go. |
|
@utkarsh2102 Thanks! |
|
Hi @iliabylich, |
mbj
reviewed
Oct 2, 2020
| .gitignore | ||
| ) | ||
|
|
||
| spec.files = Dir['bin/*', 'lib/**/*.rb', 'parser.gemspec'] |
There was a problem hiding this comment.
BTW, and this is not a bad thing: before parser would ship anything which was not gitignored explicit (or in the whitelist) this means that the parser gem will not ship tests anymore. Which is IMO a good thing.
There was a problem hiding this comment.
Yep, happy to have it this way!
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @iliabylich,
As discussed in #743, here's the PR, dropping
gitin gemspec.Rationale at: https://docs.rubocop.org/rubocop-packaging/cops_packaging.html#gemspec-git-rationale
This helps in maintaining this in Debian and other downstream 馃挮
Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>