New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
- test_current.rb: 2.8 -> 3.0 #731
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@iliabylich Maybe, we shouldn't allow failures for ruby-head? Another idea is to migrate to Github Actions and see separate statuses for different versions in PRs. And GA will likely be faster than Travis. I have a working configuration here which could be ported to this repo. |
Development branch of any repo on GH can be broken anytime. It shouldn't block us.
I look at ruby-head/rubocop statuses only when I cut a release or if I feel that PR has some potentially breaking changes. Otherwise it's useless (again, because both can be broken)
I think it's fast enough. truffleruby is slow, but MRI tests take 1.5 minutes to run. Is truffleruby faster on GH actions? 👍 if so |
Looks like slow is not the only problem 😀 Currently, I do not test against Truffle. I will check. |
I've restarted the job and now it's green (this is the 2nd failure that I've seen so far). There are a few more changes that should be done, I'll make them in a separate PR. Thanks, merging! |
~7-8 minutes: https://github.com/ruby-next/parser/runs/1057046471 I will try to provide a PR a bit later. |
Ok, let's try it. Do you want to send a PR? |
Yeah, I will try to do that tomorrow. |
Follow-up for #729