- Parser#parse returns nil instead of false if error is thrown #722
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some circumstances (when reaching the EOF too early),
racc
erroneously returnsfalse
instead ofnil
.Even though it's an upstream issue, the fix is so simple that I thought it was worthwhile to circumvent it.
This PR also improves the documentation for non-fatal cases. There are no other tests with
all_errors_are_fatal
set tofalse
.