Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

+ emit "endless method def" as :def node. #716

Merged
merged 1 commit into from Jul 1, 2020
Merged

+ emit "endless method def" as :def node. #716

merged 1 commit into from Jul 1, 2020

Conversation

iliabylich
Copy link
Collaborator

@iliabylich iliabylich commented Jun 27, 2020 •
edited

(according to #676 (comment))

2.8.0-dev is not released, so I think we are free to change it.

@iliabylich
Copy link
Collaborator Author

@marcandre PTAL, for some reason GH doesn't allow me to request a review from you

@marcandre marcandre mentioned this pull request Jun 28, 2020
Merged
marcandre
marcandre approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@marcandre marcandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iliabylich iliabylich merged commit fc32051 into whitequark:master Jul 1, 2020
@iliabylich iliabylich deleted the emit-endless-method-def-as-def-node branch July 1, 2020 11:53
@palkan
Copy link
Contributor

palkan commented Jul 2, 2020

@iliabylich I tried to migrate to this version and found that it doesn't work in a way we it was discussed: node.loc.end.nil? couldn't be used, since Map::EndlessDefinition has no #end method. Not sure what is a proper way to fix this: drop EndlessDefinition and add assignment to Definition or inherit EndlessDefinition from Definition or simply duplicate attr_accessor :end. @marcandre Thoughts?

@marcandre
Copy link
Contributor

marcandre commented Jul 2, 2020 via email

marcandre added a commit to marcandre/parser that referenced this pull request Jul 4, 2020
@marcandre
Unify locations for method and endless method definitions [whitequark…
6826c1a 
…#716]
@marcandre
Copy link
Contributor

@iliabylich I tried to migrate to this version and found that it doesn't work in a way we it was discussed: node.loc.end.nil? couldn't be used, since Map::EndlessDefinition has no #end method. Not sure what is a proper way to fix this: drop EndlessDefinition and add assignment to Definition or inherit EndlessDefinition from Definition or simply duplicate attr_accessor :end. @marcandre Thoughts?

#718 should be a good solution

marcandre added a commit to marcandre/parser that referenced this pull request Jul 6, 2020
@marcandre
Unify locations for method and endless method definitions [whitequark…
ca95288 
…#716]
iliabylich pushed a commit that referenced this pull request Jul 6, 2020
@marcandre
- unify locations for normal and endless method definition (#718)
07ab97e 
Per #716 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcandre marcandre marcandre approved these changes

@whitequark whitequark whitequark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@iliabylich @palkan @marcandre @whitequark