Rewriter optimizations #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes algorithm from `O(n^2)` to `O(n log(n))` where `n` is the order of rewriting actions
This changes the rewriting from `O(n * s)` to `O(n + s)`, where `n` is the number of rewriting actions and `s` is the length of the source
|
PS: A release when this is merged would be appreciated 😸 . Thanks |
iliabylich
approved these changes
Apr 29, 2020
|
@marcandre |
|
Thank you 😸 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two independent optimizations for the
Source::TreeRewriter.The first one changes building the tree from
O(n^2)toO(n log(n))wherenis the number of rewriting actions.The second one is of lesser importance and changes applying the tree from
O(n * s)toO(n + s), wheresis the length of the source.While I doubt users of
RuboCopwill notice the speedup but this will make a big difference for the conversion and annotation of source files into HTML byDeepCoverwhich was ridiculously slow for long source files.