+ Source::TreeRewriter: Add #merge, #merge! and #empty? #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iliabylich
requested changes
Apr 14, 2020
|
@marcandre Thanks. Do you need a release? |
|
Thanks so much for the quick review and constructive comments. I must say it is particularly appreciated tonight 😄 A release would be appreciated but is not urgent. Thanks again ❤️ |
|
Actually, might as well wait until I make a PR for |
Sure! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds methods for merging
Source::TreeRewriters.There is also a simple method to check if a
Source::TreeRewriterisempty?, i.e. if it has received any non-trivial command.I wanted to use these methods to improve the autocorrection's API of rubocop, which could benefit from building a
TreeRewriter, check if any correction was actually made, and combine them later in the process.