Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ ruby27.y: Allow trailing comma in hash pattern #661

Merged

Conversation

koic
Copy link
Collaborator

@koic koic commented Apr 1, 2020

This commit tracks upstream commit ruby/ruby@93aaa0b.

This is the following commit cherry picked from 2.8.0-dev to 2.7.1.
ruby/ruby@d25a4f4

Closes #655.

This commit tracks upstream commit ruby/ruby@93aaa0b.

This is the following commit cherry picked from 2.8.0-dev to 2.7.1.
ruby/ruby@d25a4f4

Closes whitequark#655.
Copy link
Collaborator

@iliabylich iliabylich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'm actually confused that trailing comma in array pattern changes semantics, but for hash pattern it doesn't change anything

@iliabylich iliabylich merged commit 900a652 into whitequark:master Apr 1, 2020
@koic koic deleted the allow_trailing_comma_in_hash_pattern branch April 1, 2020 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ruby/ruby@d25a4f4
2 participants