Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ruby/ruby@d746a41 #593

Open
iliabylich opened this issue Jul 5, 2019 · 2 comments
Open

ruby/ruby@d746a41 #593

iliabylich opened this issue Jul 5, 2019 · 2 comments
Labels
upstream

Comments

@iliabylich
Copy link
Collaborator

ruby/ruby@d746a41
@iliabylich
Copy link
Collaborator Author

iliabylich commented Aug 2, 2019 •
edited

@whitequark this commit adds a parsing error on ?\u{41 42}. Ruby had this error from the very beginning, but 2.5 had a bug and so it's a valid syntax for 2.5 and 2.6. However, all versions of parser reject it. Should we backport this bug? I think it's fine to keep it as is.

The fix wasn't backported into 2.5/2.6 MRI branches

@whitequark
Copy link
Owner

Seems fine to ignore this, with a README mention like usual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whitequark @iliabylich