Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ruby versions to 2.5.5 and 2.6.2. #563

Merged
merged 1 commit into from Mar 20, 2019

Conversation

iliabylich
Copy link
Collaborator

Closes #561 and #562

@whitequark
Copy link
Owner

@iliabylich I think you should be able to release yourself now.

@iliabylich iliabylich merged commit 68f33c7 into whitequark:master Mar 20, 2019
@iliabylich
Copy link
Collaborator Author

@whitequark Bump version (to 2.6.2.0 in our case) and rake release? Nothing special?

@whitequark
Copy link
Owner

Yep, just that.

@iliabylich
Copy link
Collaborator Author

Nope, still doesn't work:

Couldn't git push. `git push ' failed with the following output:

remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: Required status check "continuous-integration/travis-ci" is expected. At least 1 approving review is required by reviewers with write access.
To github.com:whitequark/parser.git
 ! [remote rejected] master -> master (protected branch hook declined)

However I see an "Edit" icon on the top right corner of Readme. Weird. Could you push it yourself please?

@whitequark
Copy link
Owner

@iliabylich I removed branch protection. I trust you wouldn't screw things up. Other collaborators also seem fine and mostly inactive anyway.

@iliabylich
Copy link
Collaborator Author

These words make me nervous. Thanks and done, parser 2.6.2.0 has been released.

@whitequark
Copy link
Owner

@iliabylich I'd add you to repo owners (which lets you bypass protection with one additional click) but it looks like GitHub only has that feature for organizations now.

@Drenmi
Copy link
Contributor

Drenmi commented Mar 21, 2019

Thanks, @whitequark and @iliabylich. 🙇

@iliabylich iliabylich deleted the bump-25-and-26-versions branch May 22, 2020 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants