Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unreachable code from lexer.rl #552

Merged
merged 1 commit into from Feb 18, 2019
Merged

Remove unreachable code from lexer.rl #552

merged 1 commit into from Feb 18, 2019

Conversation

pocke
Copy link
Collaborator

@pocke pocke commented Feb 18, 2019

It is a meaningless condition. Because it checks the version is less than 2.4, but it has been checked the version is 1.8 or 1.9.

@whitequark
Copy link
Owner

@iliabylich You've made this change in ebcd32c. Can you please look at it?

iliabylich
iliabylich approved these changes Feb 18, 2019
View reviewed changes
Copy link
Collaborator

@iliabylich iliabylich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I guess I've blindly expanded all lexpop calls to these conditions.

@pocke pocke merged commit 824ccc1 into whitequark:master Feb 18, 2019
@pocke pocke deleted the remove-unreachable-code branch February 18, 2019 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iliabylich iliabylich iliabylich approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pocke @whitequark @iliabylich