From 4d92a6c555becee06ae983a613423382876e1b99 Mon Sep 17 00:00:00 2001 From: Utkarsh Gupta Date: Fri, 25 Sep 2020 20:33:37 +0530 Subject: [PATCH] Drop `git ls-files` in gemspec Using `git` in gemspec, in general, is problematic. cf: https://docs.rubocop.org/rubocop-packaging/cops_packaging.html#gemspec-git-rationale Signed-off-by: Utkarsh Gupta --- .gitignore | 2 +- parser.gemspec | 21 +-------------------- 2 files changed, 2 insertions(+), 21 deletions(-) diff --git a/.gitignore b/.gitignore index f62dce545..84ce60fc5 100644 --- a/.gitignore +++ b/.gitignore @@ -7,7 +7,7 @@ Gemfile.lock InstalledFiles _yardoc coverage -lib/bundler/man +lib/bundler/man/* pkg rdoc yardoc diff --git a/parser.gemspec b/parser.gemspec index dcb9a4a8d..6678f9605 100644 --- a/parser.gemspec +++ b/parser.gemspec @@ -20,27 +20,8 @@ Gem::Specification.new do |spec| 'source_code_uri' => "https://github.com/whitequark/parser/tree/v#{spec.version}" } - spec.files = `git ls-files`.split + %w( - lib/parser/lexer.rb - lib/parser/ruby18.rb - lib/parser/ruby19.rb - lib/parser/ruby20.rb - lib/parser/ruby21.rb - lib/parser/ruby22.rb - lib/parser/ruby23.rb - lib/parser/ruby24.rb - lib/parser/ruby25.rb - lib/parser/ruby26.rb - lib/parser/ruby27.rb - lib/parser/ruby30.rb - lib/parser/macruby.rb - lib/parser/rubymotion.rb - ) - %w( - .gitignore - ) - + spec.files = Dir['bin/*'] + Dir['lib/**/*.rb'] + 'parser.gemspec' spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) } - spec.test_files = spec.files.grep(%r{^test/}) spec.require_paths = ['lib'] spec.required_ruby_version = '>= 2.0.0'