Fixed AST::Node#updated to always return a copy. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you split code and CI changes in separate commits? Other than that LGTM |
Currently it relies on a call chain #initialize -> #freeze that returns `self`. However, overriding constructor in a custom subclass and returning something else breaks `updated`.
iliabylich
force-pushed
the
fix-updated-method-for-subclasses
branch
from
0f9e92d
to
239014d
Compare
|
@whitequark What is the versioning strategy here? Should the next version be |
|
That's a bugfix AFAIU, so yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it relies on a call chain #initialize -> #freeze that returns
self.However, overriding constructor in a custom subclass and returning something else breaks
updated.Included a test case. Without my fix
updatedreturnsnil.