Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor get_preferred_protocol_address #65

Open
rubdos opened this issue Jan 31, 2021 · 0 comments
Open

Refactor get_preferred_protocol_address #65

rubdos opened this issue Jan 31, 2021 · 0 comments
Assignees
@gferon

Comments

@rubdos
Copy link
Member

rubdos commented Jan 31, 2021

Things like bd7f9ee slip through reviews often.

  1. I think we might want to have get_preferred_protocol_address() as a method on either Address (as constructor), on StorageContext (as provided method) or as method on ServiceAddress (as conversion method into an Address).
  2. I think we may want StoreContext::get_sub_device_sessions to accept a ServiceAddress instead of an Address, or make a provided method on the trait.

Both these items correspond to an XXX in the above commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gferon gferon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gferon @rubdos