Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code duplication in Service implementations. #63

Open
rubdos opened this issue Jan 28, 2021 · 1 comment
Open

Code duplication in Service implementations. #63

rubdos opened this issue Jan 28, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@rubdos
Copy link
Member

rubdos commented Jan 28, 2021

get/put/post/delete share a whole lot of code, but they differ ever so slightly in their implementation. Should probably be rewired through a macro.

@rubdos rubdos added the enhancement New feature or request label Jan 28, 2021
@gferon
Copy link
Collaborator

gferon commented Mar 4, 2021

It should already be improved by work in #73 and the future hyper implementation has even more shared code compared to the actix one #spoiler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants