Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MessageSender::send_contact_details seems to have some parameters too many #294

Open
rubdos opened this issue Mar 9, 2024 · 0 comments
Open

Comments

@rubdos
Copy link
Member

rubdos commented Mar 9, 2024

I'm working on #206, and I'm adding the include_pni_signature bool everywhere. I notice that send_contact_details has the online parameter and the recipient parameter, but the former should always be false, and the latter is always the self-recipient. So we'll want to clean that out.

Or am I missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant