Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use DeviceId type from libsignal #173

Open
gferon opened this issue Nov 7, 2022 · 0 comments
Open

Use DeviceId type from libsignal #173

gferon opened this issue Nov 7, 2022 · 0 comments
Labels
good first issue Good for newcomers

Comments

@gferon
Copy link
Collaborator

gferon commented Nov 7, 2022

Throughout the codebase, we sometimes use primitive types like u32 where libsignal introduced custom types (mostly to improve readability, sometimes to introduce functionnality). DeviceId is one of the types we haven't started to use yet in our codebase.

For example, the sender_device field in the Metadata struct should make use of libsignal_protocol::DeviceId.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant