Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-export curve25519-dalek features from libsignal-client #138

Open
nworbnhoj opened this issue Mar 10, 2022 · 3 comments
Open

re-export curve25519-dalek features from libsignal-client #138

nworbnhoj opened this issue Mar 10, 2022 · 3 comments

Comments

@nworbnhoj
Copy link

I recently opened an issue/request for libsignal-client to re-export curve25519-dalek features

Assuming this request is successful I hope that libsignal-service-rs/Cargo.toml might also re-export curve25519-dalek features?

nightly = [libsignal-client/nightly]
default = [libsignal-client/default]
std = [libsignal-client/std]
alloc = [libsignal-client/alloc]
u32_backend = [libsignal-client/u32_backend]
u64_backend = [libsignal-client/u64_backend]
simd_backend = [libsignal-client/simd_backend]

In particular I am seeking std and u32_backend - and include the others for sake of completeness.

@rubdos
Copy link
Member

rubdos commented Mar 11, 2022

What's the reasoning behind this? You can include curve25519-dalek yourself in Cargo.toml and set the desired feature set there, I'd think. Neither this crate nor libsignal-client need access to these features.

@nworbnhoj
Copy link
Author

nworbnhoj commented Mar 12, 2022

As I understand it - features can be specified at the command line or in Cargo.toml - but only in code with a direct dependency on libsignal-client (in this case). libsignal-service-rs must re-export these features for them to be available to subsequent dependents (such as presage or xous-core).

In my case (Signal App on the Precursor) I need to set default-features=false to disable the default u64_backend and then set feature=u32_backend

@rubdos
Copy link
Member

rubdos commented Mar 12, 2022

I did a bit of digging, and indeed the default-features=false comes back to bite you.

I'll continue the discussion on signalapp/libsignal#453.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants