Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bracketed paste not working in Helix #4236

Open
chtenb opened this issue Sep 2, 2023 · 7 comments
Open

Bracketed paste not working in Helix #4236

chtenb opened this issue Sep 2, 2023 · 7 comments
Labels
bug Something isn't working Windows Issue applies to Microsoft Windows

Comments

@chtenb
Copy link
Sponsor

chtenb commented Sep 2, 2023

What Operating System(s) are you seeing this problem on?

Windows

Which Wayland compositor or X11 Window manager(s) are you using?

No response

WezTerm version

20230828-220414-99c96139

Did you try the latest nightly build to see if the issue is better (or worse!) than your current version?

Yes, and I updated the version box above to show the version of the nightly that I tried

Describe the bug

  • Helix supports bracketed paste Bracketed paste helix-editor/helix#2239
    This means I should be able to copy the system clipboard using shift-insert or ctrl-shift-v in insert mode into the helix buffer.
  • I've verified that this works when I start Helix in Windows Terminal.
  • When I open Vim in wezterm, pasting chunks of texts also just works.
  • However, the combination Helix/Wezterm specifically does not work correctly. Pasting chunks of texts results in a very slow pasting operation where all newlines are stripped out.

I'm a little bit at a loss and I don't know what part of the software chain is "at fault". It seems weird to me that specifically this combination does not work.

To Reproduce

Use the newest Helix version and wezterm, open hx and paste a multi-line piece of text from the system clipboard in insert mode.

Configuration

no config

Expected Behavior

No response

Logs

Nothing in the debug logs

Anything else?

If you need me to try anything for debugging purposes, I'd be happy to.
Perhaps the following links are relevant

@chtenb chtenb added the bug Something isn't working label Sep 2, 2023
@wez
Copy link
Owner

wez commented Sep 2, 2023

Please capture a terminal recording:

  • Launch wezterm. If possible, please use the default terminal size of 80x24 cells as it helps to keep things smaller and easier to manage.
  • Inside that terminal run wezterm record to start a recording session.
  • Run through your reproduction steps
  • Then type exit
  • You should see a message like:
*** Finished recording to /var/tmp/wezterm-recording-sF6B3u.cast.txt
  • Attach the file that it produced to this issue.

The file is an asciicast (compatible with https://asciinema.org/) and can also be replayed using wezterm replay.

The terminal recording allows me to replicate what is being sent to the terminal without requiring me to install the same applications as you and replicate your configuration for everything.

@wez wez added the waiting-on-op Waiting for more information from the original poster label Sep 2, 2023
@wez
Copy link
Owner

wez commented Sep 2, 2023

A relevant configuration option is: https://wezfurlong.org/wezterm/config/lua/config/canonicalize_pasted_newlines.html
However, it shouldn't affect things when bracketed paste is active.

Is helix a native win32 application, or are you running it via WSL?
If the latter, consider trying to wezterm ssh into the WSL host to see if the issue is introduced by ConPTY.

@chtenb
Copy link
Sponsor Author

chtenb commented Sep 3, 2023

wezterm-recording-M06nrM.cast.txt

I didn't have much luck in recording, for some reason all kinds of escape sequences are inserted, which does not happen when not recording.

@github-actions github-actions bot removed the waiting-on-op Waiting for more information from the original poster label Sep 3, 2023
@wez
Copy link
Owner

wez commented Sep 3, 2023

@wez wez added the waiting-on-op Waiting for more information from the original poster label Sep 3, 2023
@chtenb
Copy link
Sponsor Author

chtenb commented Sep 4, 2023

That doesn't help unfortunately. (I added allow_win32_input_mode = false, to my config, and restarted wezterm).

@github-actions github-actions bot removed the waiting-on-op Waiting for more information from the original poster label Sep 4, 2023
@chtenb
Copy link
Sponsor Author

chtenb commented Sep 5, 2023

I tried recording with asciinema to see if that would make a difference, but asciinema appears to crash immediately on a module that is not available for windows :(

@chtenb
Copy link
Sponsor Author

chtenb commented Sep 5, 2023

EDIT: created separate issue, because probably unrelated #4255

@wez wez added the Windows Issue applies to Microsoft Windows label Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Windows Issue applies to Microsoft Windows
Projects
None yet
Development

No branches or pull requests

2 participants