[bug] useContractReads data instability

[matthewlilley]

Is there an existing issue for this?

• I have searched the existing issues

Package Version

latest

Current Behavior

useContractReads returns unstable data, equality is always lost despite underlying data being exactly the same

Expected Behavior

In cases where the underlying data has not changed, for equality to be preserved.

Steps To Reproduce

repro below

Link to Minimal Reproducible Example (CodeSandbox, StackBlitz, etc.)

https://codesandbox.io/s/small-smoke-2i7b0q?file=/src/App.js

[tmm]

Off chance this might be related TanStack/query#3772

[matthewlilley]

Might be useful to look at for this one: https://github.com/Uniswap/redux-multicall/blob/main/src/hooks.ts#L55

[jxom]

Opened a fix here: #659.

React Query's data comparison function does not support the ethers Result type as it is not JSON serializable. I have added an isDataEqual flag that defaults to our implementation of deepEqual (RQ also does a deep equal implementation for their structural sharing), but you can also provide your own (like you did here)! What do you think?

[matthewlilley]

Result

That makes sense, feels like this would be a valuable PR to ethers too now I think about it. I wonder if the same is true for ethers v6. Yeah, it seems this would work, but would like to test if you'd put up a pre-release version. I'd be happy to do that if you can.

[jxom]

@matthewlilley – can you check 0.5.7?

[github-actions]

This issue has been locked since it has been closed for more than 14 days.

If you found a concrete bug or regression related to it, please open a new bug report with a reproduction against the latest wagmi version. If you have any other comments you can create a new discussion.