Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __init_subclass__ to the methods order #2411

Merged

Conversation

Bobronium
Copy link
Contributor

Add __init_subclass__ to WPS338 order.

New allowed methods order:

  • __init_subclass__
  • __new__
  • __init__
  • __call__
  • __await__

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Related issues

Closes #2410

馃檹 Please, if you or your company is finding wemake-python-styleguide valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/wemake-python-styleguide. As a thank you, your profile/company logo will be added to our main README which receives hundreds of unique visitors per day.

@Bobronium Bobronium mentioned this pull request Apr 29, 2022
4 tasks
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@codecov
Copy link

codecov bot commented Apr 30, 2022

Codecov Report

Merging #2411 (3786a48) into master (3daaea4) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #2411   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          120       120           
  Lines         6408      6408           
  Branches      1445      1445           
=========================================
  Hits          6408      6408           
Impacted Files Coverage 螖
wemake_python_styleguide/violations/consistency.py 100.00% <酶> (酶)
wemake_python_styleguide/visitors/ast/classes.py 100.00% <酶> (酶)

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 3daaea4...3786a48. Read the comment docs.

@sobolevn sobolevn merged commit 88afa8c into wemake-services:master Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add __init_subclass__ to the order of methods in WPS338
2 participants