Add full violations codes to docs #2409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bobronium
changed the title
sobolevn
requested changes
Apr 29, 2022
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Bobronium
commented
Apr 29, 2022
| # We use this code to show base metrics and thresholds mostly: | ||
| postfix_template: ClassVar[ViolationPostfixes] = ( | ||
| ViolationPostfixes.bigger_than | ||
| ) | ||
|
|
||
| def __init_subclass__(cls) -> None: |
There was a problem hiding this comment.
This causes WPS338 error. Considering that #2411 is in place, what should be our course of action?
I see the following options:
- Suppress the error until Add __init_subclass__ to the methods order聽#2411 gets released
- Obey current rules of ordering, refactor once Add __init_subclass__ to the methods order聽#2411 gets released
- Do nothing, wait until Add __init_subclass__ to the methods order聽#2411 gets released
|
Sorry for the initial mess. I believe now the only thing that would make CI unhappy is WPS338 (#2409 (comment)) |
Bobronium
commented
Apr 30, 2022
Codecov Report
@@ Coverage Diff @@
## master #2409 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 120 120
Lines 6408 6425 +17
Branches 1445 1447 +2
=========================================
+ Hits 6408 6425 +17
Continue to review full report at Codecov.
|
sobolevn
approved these changes
Apr 30, 2022
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made full violations codes indexable
Finally, people searching for
WPS527 Sovereign Starter Motorwill see that WPS truly means!Changes
BaseViolation.__doc__BaseViolation.full_codeclass varBaseViolation.summaryclass carBaseViolation._full_nameis now aclassmethodHow it looks in docs
Checklist
CHANGELOG.mdRelated issues
Closes #2288
Closes #1145
馃檹 Please, if you or your company is finding wemake-python-styleguide valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/wemake-python-styleguide. As a thank you, your profile/company logo will be added to our main README which receives hundreds of unique visitors per day.