Fix magic method yields (__next__, __anext__, __aiter__) #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
requested changes
Apr 22, 2022
| oop.AsyncMagicMethodViolation(node, text=node.name), | ||
| ) | ||
| can_async = node.name in constants.ASYNC_IF_YIELDS_MAGIC_METHODS | ||
| if not (can_async and walk.is_contained(node, (ast.Yield))): |
There was a problem hiding this comment.
Suggested change
| if not (can_async and walk.is_contained(node, (ast.Yield))): | |
| if not (can_async and walk.is_contained(node, ast.Yield)): |
|
I'll work on figuring out how to do the tests and hopefully have something by the end of the week. |
|
__anext__: This is a runtime constraint. __anext__ cannot be a generator. This will cause the runtime to throw a TypeError when used in an async for loop. __next__: The usefulness of having __next__ be a generator is practically nil. Doing so will cause an infinite loop with a new generator object passed to each iteration.
__aiter__ can only contain yield if it is an async function (async generator). Otherwise it must be a sync function that does not contain yield and returns an object that implements __anext__.
sobolevn
force-pushed
the
pr-fix-magic-method-yields
branch
from
79168c1
to
6fbad72
Compare
Codecov Report
@@ Coverage Diff @@
## master #2400 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 119 119
Lines 6383 6390 +7
Branches 1446 1449 +3
=========================================
+ Hits 6383 6390 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Checklist
CHANGELOG.mdRelated issues
Closes #2399
馃檹 Please, if you or your company is finding wemake-python-styleguide valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/wemake-python-styleguide. As a thank you, your profile/company logo will be added to our main README which receives hundreds of unique visitors per day.