Refs #1850 #1856
Merged
Refs #1850 #1856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1856 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 109 109
Lines 6038 6038
Branches 1348 1348
=========================================
Hits 6038 6038
Continue to review full report at Codecov.
|
sobolevn
commented
Feb 8, 2021
| @@ -43,7 +43,7 @@ def is_valid_unpacking_target(target: ast.expr) -> bool: | |||
| """Checks if unpacking target is correct.""" | |||
| if isinstance(target, ast.Tuple): | |||
| return all( | |||
| _is_valid_single(element) is not None | |||
| _is_valid_single(element) | |||
There was a problem hiding this comment.
@skarzi changed!
It looks like this can break some tests 馃槰
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Checklist
CHANGELOG.mdRelated issues
馃檹 Please, if you or your company is finding wemake-python-styleguide valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/wemake-python-styleguide. As a thank you, your profile/company logo will be added to our main README which receives hundreds of unique visitors per day.