Closes #1684 #1850
Merged
Closes #1684 #1850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -11,7 +11,7 @@ | |||
| from wemake_python_styleguide.logic import walk | |||
| from wemake_python_styleguide.logic.naming import name_nodes | |||
| from wemake_python_styleguide.logic.nodes import get_parent | |||
| from wemake_python_styleguide.logic.tree import keywords, operators | |||
| from wemake_python_styleguide.logic.tree import keywords, operators, variables | |||
There was a problem hiding this comment.
[pep8] reported by reviewdog 馃惗
F401 'wemake_python_styleguide.logic.tree.variables' imported but unused
Codecov Report
@@ Coverage Diff @@
## master #1850 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 107 107
Lines 5991 5992 +1
Branches 1341 1343 +2
=========================================
+ Hits 5991 5992 +1
Continue to review full report at Codecov.
|
skarzi
reviewed
Feb 8, 2021
| """Checks if unpacking target is correct.""" | ||
| if isinstance(target, ast.Tuple): | ||
| return all( | ||
| _is_valid_single(element) is not None |
There was a problem hiding this comment.
_is_valid_single returns bool so why the result is compared to None?
Shouldn't it be just _is_valid_single(element)?
sobolevn
added a commit
that referenced
this pull request
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Checklist
CHANGELOG.mdRelated issues
馃檹 Please, if you or your company is finding wemake-python-styleguide valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/wemake-python-styleguide. As a thank you, your profile/company logo will be added to our main README which receives hundreds of unique visitors per day.