Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add __call__ to list of methods that should be on top #1125

Closed
sobolevn opened this issue Jan 26, 2020 · 3 comments
Closed

Add __call__ to list of methods that should be on top #1125

sobolevn opened this issue Jan 26, 2020 · 3 comments
Assignees
@gillesigot
Labels
feature New feature or request help wanted Extra attention is needed level:starter Good for newcomers
Milestone
Version 0.14 aka ...

Comments

@sobolevn
Copy link
Member

sobolevn commented Jan 26, 2020 •
edited

I guess that the order should be the following:

  • __new__
  • __init__
  • __call__

Things to edit:

  1. wemake-python-styleguide/wemake_python_styleguide/violations/consistency.py

    Line 1516 in 06e9426

    - ``__new__``

  2. wemake-python-styleguide/wemake_python_styleguide/visitors/ast/classes.py

    Line 410 in e84e767

    if first == '__new__':
  3. https://github.com/wemake-services/wemake-python-styleguide/blob/f5447577113bd4c7c397a0e7970a62908bd11f73/tests/test_visitors/test_ast/test_classes/test_method_order.py
@sobolevn sobolevn added feature New feature or request help wanted Extra attention is needed level:starter Good for newcomers labels Jan 26, 2020
@sobolevn sobolevn added this to the Version 0.14 aka python3.8 milestone Jan 26, 2020
@gillesigot
Copy link
Contributor

gillesigot commented Jan 27, 2020 •
edited

Hello! May I take it?

@sobolevn
Copy link
Member Author

Sure! Thanks a lot!

gillesigot pushed a commit to gillesigot/wemake-python-styleguide that referenced this issue Jan 30, 2020
Add __call__ to list of methods that should be on top wemake-servic…
b13f3c0 
…es#1125
gillesigot pushed a commit to gillesigot/wemake-python-styleguide that referenced this issue Feb 2, 2020
Add __call__ to list of methods that should be on top wemake-servic…
b398ede 
…es#1125
sobolevn added a commit that referenced this issue Feb 2, 2020
@gillesigot @sobolevn
Add __call__ to list of methods that should be on top #1125 (#1129)
62d16d6 
* Add `__call__` to list of methods that should be on top #1125

* Fixes variable name

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@sobolevn
Copy link
Member Author

sobolevn commented Feb 2, 2020

Closed by #1129

@sobolevn sobolevn closed this as completed Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gillesigot gillesigot

Labels
feature New feature or request help wanted Extra attention is needed level:starter Good for newcomers
Projects
None yet
Milestone
Version 0.14 aka python3.8
Development

No branches or pull requests
2 participants
@sobolevn @gillesigot