Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve boolean non-keyword arguments validation #1114

Merged
merged 1 commit into from Jan 18, 2020

Conversation

skarzi
Copy link
Collaborator

@skarzi skarzi commented Jan 18, 2020

I have made things!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Related issues

Closes: #1104

Allow passing booleans as non-keyword argument when it is the only
one passed argument.

馃檹 Please, if you or your company is finding wemake-python-styleguide valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/wemake-python-styleguide. As a thank you, your profile/company logo will be added to our main README which receives hundreds of unique visitors per day.

Allow passing booleans as non-keyword argument when it is the only
one passed argument.
@coveralls
Copy link

coveralls commented Jan 18, 2020

Pull Request Test Coverage Report for Build 2500

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 2499: 0.0%
Covered Lines: 5029
Relevant Lines: 5029

馃挍 - Coveralls

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@sobolevn sobolevn merged commit 70d4a51 into wemake-services:master Jan 18, 2020
@skarzi skarzi deleted the issue-1104 branch January 18, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WPS245 on single argument functions
3 participants