Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update violation docs for yield from violation. #1062

Merged
merged 4 commits into from Dec 9, 2019
Merged

Update violation docs for yield from violation. #1062

merged 4 commits into from Dec 9, 2019

Conversation

andreaestrada
Copy link
Contributor

@andreaestrada andreaestrada commented Dec 8, 2019 •
edited by sobolevn

Address issue #1057. Update violation docs to make it easier for developers to understand how to refactor more complex yield statements.

I have made things!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
  • [NA - documentation only] I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Related issues

Closes #1057, closes #1044

@andreaestrada
Update violation docs for yield from violation.
0e77833 
Address issue wemake-services#1057. Update violation docs to make it easier for developers to understand how to refactor more complex yield statements.
@coveralls
Copy link

coveralls commented Dec 8, 2019 •
edited

Pull Request Test Coverage Report for Build 2410

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 2391: 0.0%
Covered Lines: 5025
Relevant Lines: 5025
💛 - Coveralls

@sobolevn sobolevn merged commit a00d479 into wemake-services:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positive implicit yield violation Incorrect message for WPS349
3 participants
@andreaestrada @coveralls @sobolevn